[Routing] Add Attribute code examples for alias in #[Route] attribute
#20638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienfern
suggested changes
Feb 10, 2025
welcoMattic
force-pushed
the
alias-route-attribute
branch
from
5ccc81e to
d65f27b
Compare
|
@stof for review I've fixed issues we talk about in private. But, as we discussed, we need to make this Route Alias part of the documentation a bit clearer on lower branches. This PR documents the new way to create route aliases using Attributes (which differs from the way to do in YAML, XML and PHP, if I've understood correctly). |
damienfern
reviewed
Feb 19, 2025
Spomky
approved these changes
Apr 2, 2025
OskarStark
added a commit
that referenced
this pull request
May 20, 2025
… route names (welcoMattic) This PR was squashed before being merged into the 6.4 branch. Discussion ---------- [Routing] Clarify route aliases examples with explicit route names Refers to #20638 (comment) Actual examples for route aliasing are not crystal clear. Now, examples in YAML, XML and PHP provide - An original route, declared with an explicit name - An alias to this route, with an explicit name This change will allow to provide another clear example for route aliasing using Attribute in #20638 cc `@stof` `@damienfern` Commits ------- a28b614 [Routing] Clarify route aliases examples with explicit route names
welcoMattic
force-pushed
the
alias-route-attribute
branch
from
d65f27b to
848f249
Compare
|
@symfony/docs I reworked this PR to only add PHP Attribute code blocks about Route Aliasing and Deprecated Route Aliases. Your review is welcome 🙏 Status: Needs review |
stof
approved these changes
May 20, 2025
OskarStark
changed the title
#[Route] attribute
OskarStark
reviewed
May 20, 2025
OskarStark
approved these changes
May 20, 2025
welcoMattic
commented
May 20, 2025
|
|
||
| So that you can use your own route name for URL generation, | ||
| while actually using a route defined by a third-party bundle as the target of that URL generation, | ||
| as the 2 definitions are not required to be in the same config file (or even in the same format). |
There was a problem hiding this comment.
@OskarStark @stof I've added this side note, is it ok for you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20600
This one adds code examples to alias route in
#[Route]attribute. It also add example usingDeprecatedAlias.I've also added a note to precise
new_route_nameandoriginal_route_namemeaning, to avoid misunderstanding.cc @damienfern