Skip to content

[FrameworkBundle] Make StopWorkerOnSignalsListener configurable via messenger's config#18113

Merged
javiereguiluz merged 1 commit intosymfony:7.4from
alexandre-daubois:stopworkeronsignals
Mar 13, 2026
Merged

[FrameworkBundle] Make StopWorkerOnSignalsListener configurable via messenger's config#18113
javiereguiluz merged 1 commit intosymfony:7.4from
alexandre-daubois:stopworkeronsignals

Conversation

@alexandre-daubois
Copy link
Member

Waiting code merge of symfony/symfony#49750

@carsonbot carsonbot added this to the 6.3 milestone Mar 22, 2023
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Mar 22, 2023
@carsonbot carsonbot modified the milestones: 6.3, next Mar 22, 2023
messenger.rst Outdated
framework:
messenger:
stop_worker_on_signals:
- SIGINT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is SIGINT in this option? A string? ('SIGINT') A PHP constant? (!php/const:SIGINT) Other? Thanks.

Copy link
Member Author

@alexandre-daubois alexandre-daubois Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the code PR gets accepted as is, it will be strings. That's updated, thanks for pointing this out!

@javiereguiluz javiereguiluz added Status: Reviewed and removed Waiting Code Merge Docs for features pending to be merged Status: Needs Review labels Mar 13, 2026
@javiereguiluz javiereguiluz modified the milestones: next, 7.3 Mar 13, 2026
@javiereguiluz javiereguiluz changed the base branch from 6.3 to 7.4 March 13, 2026 08:16
@javiereguiluz
Copy link
Member

It took us forever to merge this, but we finally did that. Thanks a lot Alex!

@javiereguiluz javiereguiluz merged commit 1d2e1f9 into symfony:7.4 Mar 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants