Skip to content

[Config] [Misc] Fixed remaining HEAD #17811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

alexandre-daubois
Copy link
Member

Even if 6.0 is unreleased, I guess it is still relevant to fix this on this branch 🙂

@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.2, 6.3.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.0 milestone Jan 26, 2023
@carsonbot carsonbot changed the title [Misc] Fixed remaining HEAD [Config] [Misc] Fixed remaining HEAD Jan 26, 2023
@javiereguiluz
Copy link
Member

Yes, let's fix this mistake in 6.0 even if it's no longer maintained. Thanks a lot and good catch Alex!

@javiereguiluz javiereguiluz merged commit 779e983 into symfony:6.0 Jan 26, 2023
@alexandre-daubois alexandre-daubois deleted the fix-remaining-heads branch January 26, 2023 12:57
@@ -106,23 +106,6 @@ readable. These are the main advantages and disadvantages of each format:
}
}

<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamirault could be an easy rule for doctor to spot merge conflicts 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants