[String] Replace codePoint by codePointsAt #12876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added a commit
that referenced
this pull request
Jan 2, 2020
This PR was merged into the 5.0 branch. Discussion ---------- [String] Replace codePoint by codePointsAt symfony/symfony#33940 renamed the `codePoint` method to `codePointsAt`. Commits ------- d507793 [String] Replace codePoint by codePointsAt
|
Good catch! Thanks Thomas! I've tweaked this a bit while merging to update the associated comment and mention that the returned value is an array. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#33940 renamed the
codePointmethod tocodePointsAt.