Skip to content

[Notifier] Add iSendPro bridge #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

[Notifier] Add iSendPro bridge #1147

merged 1 commit into from
Dec 2, 2022

Conversation

leblanc-simon
Copy link
Contributor

Q A
License MIT
Doc issue/PR symfony/symfony-docs#17450

Add the recipe for the new iSendPro notifier. Related with the PR : symfony/symfony#48253

@symfony-recipes-bot symfony-recipes-bot enabled auto-merge (squash) November 20, 2022 17:25
@github-actions
Copy link

github-actions bot commented Nov 20, 2022 •
edited
Loading

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1147/index.json
# On Windows
SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes/flex/pull-1147/index.json

  2. Install the package(s) related to this recipe:

    composer req 'symfony/flex:^1.16'
composer req 'symfony/isendpro-notifier:^6.3'

  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
unset SYMFONY_ENDPOINT
# On Windows
SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@leblanc-simon leblanc-simon mentioned this pull request Nov 20, 2022
Closed
@leblanc-simon leblanc-simon mentioned this pull request Nov 29, 2022
Merged
fabpot added a commit to symfony/symfony that referenced this pull request Dec 2, 2022
@fabpot
feature #48399 [Notifier] Add iSendPro bridge (leblanc-simon)
f17a4a6 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add iSendPro bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17450
|Recipe         | symfony/recipes#1147

This PR add the notifier bridge for [Isendpro](https://www.isendpro.com/) (SMS).

Replace the #48253 (I failed to target new branch with Git, sorry...)

Commits
-------

695d5eb [Notifier] Add iSendPro bridge
symfony-splitter pushed a commit to symfony/notifier that referenced this pull request Dec 2, 2022
@fabpot
feature #48399 [Notifier] Add iSendPro bridge (leblanc-simon)
c186f99 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add iSendPro bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17450
|Recipe         | symfony/recipes#1147

This PR add the notifier bridge for [Isendpro](https://www.isendpro.com/) (SMS).

Replace the #48253 (I failed to target new branch with Git, sorry...)

Commits
-------

695d5ebe8c [Notifier] Add iSendPro bridge
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Dec 2, 2022
@fabpot
feature #48399 [Notifier] Add iSendPro bridge (leblanc-simon)
cce5457 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add iSendPro bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17450
|Recipe         | symfony/recipes#1147

This PR add the notifier bridge for [Isendpro](https://www.isendpro.com/) (SMS).

Replace the #48253 (I failed to target new branch with Git, sorry...)

Commits
-------

695d5ebe8c [Notifier] Add iSendPro bridge
@fabpot fabpot disabled auto-merge December 2, 2022 16:23
@fabpot fabpot merged commit 79b723c into symfony:main Dec 2, 2022
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Jul 28, 2023
@fabpot
feature #48399 [Notifier] Add iSendPro bridge (leblanc-simon)
3f2b4f0 
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Add iSendPro bridge

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#17450
|Recipe         | symfony/recipes#1147

This PR add the notifier bridge for [Isendpro](https://www.isendpro.com/) (SMS).

Replace the #48253 (I failed to target new branch with Git, sorry...)

Commits
-------

695d5ebe8c [Notifier] Add iSendPro bridge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Waiting Code Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leblanc-simon @fabpot @OskarStark