Skip to content

Add recipes for sylius/mollie-plugin:3.0 #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wojdylak
Copy link
Contributor

Q A
License MIT
Packagist

@Wojdylak Wojdylak marked this pull request as draft May 20, 2025 09:33
Copy link

github-actions bot commented May 20, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1801/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/symfony/recipes-contrib/flex/pull-1801/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 'sylius/mollie-plugin:^3.0'
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

sylius/mollie-plugin

1.0 vs 2.0
diff --git a/sylius/mollie-plugin/1.0/config/packages/sylius_mollie.yaml b/sylius/mollie-plugin/2.0/config/packages/sylius_mollie.yaml
index 75868dbe..f8a2c711 100644
--- a/sylius/mollie-plugin/1.0/config/packages/sylius_mollie.yaml
+++ b/sylius/mollie-plugin/2.0/config/packages/sylius_mollie.yaml
@@ -1,2 +1,2 @@
 imports:
-    - { resource: "@SyliusMolliePlugin/Resources/config/config.yaml" }
+    - { resource: "@SyliusMolliePlugin/config/config.yaml" }
diff --git a/sylius/mollie-plugin/1.0/config/routes/sylius_mollie.yaml b/sylius/mollie-plugin/2.0/config/routes/sylius_mollie.yaml
index d96ad31f..710ab576 100644
--- a/sylius/mollie-plugin/1.0/config/routes/sylius_mollie.yaml
+++ b/sylius/mollie-plugin/2.0/config/routes/sylius_mollie.yaml
@@ -1,2 +1,2 @@
 sylius_mollie_plugin:
-    resource: "@SyliusMolliePlugin/Resources/config/routing.yaml"
+    resource: "@SyliusMolliePlugin/config/routes.yaml"
diff --git a/sylius/mollie-plugin/1.0/manifest.json b/sylius/mollie-plugin/2.0/manifest.json
index 47ee35f7..23076eea 100644
--- a/sylius/mollie-plugin/1.0/manifest.json
+++ b/sylius/mollie-plugin/2.0/manifest.json
@@ -1,20 +1,26 @@
 {
     "bundles": {
-        "SyliusMolliePlugin\\SyliusMolliePlugin": ["all"]
+        "Sylius\\MolliePlugin\\SyliusMolliePlugin": ["all"]
     },
     "copy-from-recipe": {
         "config/": "%CONFIG_DIR%/"
     },
     "add-lines": [
         {
-            "file": "assets/admin/entry.js",
-            "content": "import '../../vendor/sylius/mollie-plugin/src/Resources/assets/admin/entry';",
+            "file": "templates/bundles/SyliusShopBundle/_scripts.html.twig",
+            "content": "<script src=\"https://js.mollie.com/v1/mollie.js\"></script>",
+            "position": "top",
+            "warn_if_missing": true
+        },
+        {
+            "file": "assets/admin/entrypoint.js",
+            "content": "import '../../vendor/sylius/mollie-plugin/assets/admin/entrypoint';",
             "position": "bottom",
             "warn_if_missing": true
         },
         {
-            "file": "assets/shop/entry.js",
-            "content": "import '../../vendor/sylius/mollie-plugin/src/Resources/assets/shop/entry';",
+            "file": "assets/shop/entrypoint.js",
+            "content": "import '../../vendor/sylius/mollie-plugin/assets/shop/entrypoint';",
             "position": "bottom",
             "warn_if_missing": true
         }
2.0 vs 3.0
diff --git a/sylius/mollie-plugin/2.0/manifest.json b/sylius/mollie-plugin/3.0/manifest.json
index 23076eea..cb1c2c7f 100644
--- a/sylius/mollie-plugin/2.0/manifest.json
+++ b/sylius/mollie-plugin/3.0/manifest.json
@@ -6,21 +6,15 @@
         "config/": "%CONFIG_DIR%/"
     },
     "add-lines": [
-        {
-            "file": "templates/bundles/SyliusShopBundle/_scripts.html.twig",
-            "content": "<script src=\"https://js.mollie.com/v1/mollie.js\"></script>",
-            "position": "top",
-            "warn_if_missing": true
-        },
         {
             "file": "assets/admin/entrypoint.js",
-            "content": "import '../../vendor/sylius/mollie-plugin/assets/admin/entrypoint';",
+            "content": "import '@vendor/sylius/mollie-plugin/assets/admin/entrypoint';",
             "position": "bottom",
             "warn_if_missing": true
         },
         {
             "file": "assets/shop/entrypoint.js",
-            "content": "import '../../vendor/sylius/mollie-plugin/assets/shop/entrypoint';",
+            "content": "import '@vendor/sylius/mollie-plugin/assets/shop/entrypoint';",
             "position": "bottom",
             "warn_if_missing": true
         }

@Wojdylak Wojdylak force-pushed the add-recipes-for-mollie-3.0 branch from b099f26 to 46f763e Compare May 20, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant