Upgrade to PHPStan v2 #1768
Merged
Upgrade to PHPStan v2 #1768
+57
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request upgrades PHPStan from version 1.x to version 2.x, updating the main package and all related extensions to their latest major versions.
Key Changes:
- Upgraded PHPStan core and extension packages to v2
- Updated PHPStan suppression comments to use the new v2 syntax format
- Removed named parameters from test assertions to comply with PHPStan v2 requirements
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/phpstan/composer.json | Updated PHPStan and all extension packages to v2 |
| tests/Maker/MakeSerializerEncoderTest.php | Removed named parameters from assertions |
| tests/Maker/MakeControllerTest.php | Removed named parameters from assertions |
| tests/Command/MakerCommandTest.php | Updated PHPStan suppression comment to v2 syntax |
| src/Maker/MakeUser.php | Updated PHPStan suppression comment to v2 syntax |
| src/Maker/MakeStimulusController.php | Updated PHPStan suppression comment to v2 syntax |
| src/Maker/MakeResetPassword.php | Updated PHPStan suppression comment to v2 syntax |
| CONTRIBUTING.md | Added new contributing documentation with testing and static analysis instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
stof
reviewed
Jan 9, 2026
src/Maker/MakeStimulusController.php
Outdated
| public function configureDependencies(DependencyBuilder $dependencies): void | ||
| { | ||
| // lower than 8.1, allow WebpackEncoreBundle | ||
| // @phpstan-ignore smaller.alwaysFalse |
Member
There was a problem hiding this comment.
phpstan is actually right. This is dead code due to the PHP requirement in composer.json.
Member
Author
There was a problem hiding this comment.
Good point, I removed the dependency on webpack encore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.