Skip to content

Add option to specify version in add lines requires #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from
Open

Add option to specify version in add lines requires #1055

wants to merge 1 commit into from

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented May 29, 2025 •
edited
Loading

Currently, when requiring symfony/panther, Flex adds the following two lines to phpunit.dist.xml:

<extensions>
+    <bootstrap class="Symfony\Component\Panther\ServerExtension" />
+    <extension class="Symfony\Component\Panther\ServerExtension" />
</extensions>

This isn't entirely correct: the extension tag is used for PHPUnit <10, while bootstrap is used for PHPUnit >=10.

This PR adds support for specifying the required package version for each line, so only the appropriate one is added.

Recipes PR: symfony/recipes#1422

@HypeMC HypeMC mentioned this pull request May 29, 2025
Open
@HypeMC HypeMC force-pushed the add-version-to-add-lines-requires branch from aac19ea to 24b10a8 Compare May 29, 2025 18:00
@HypeMC HypeMC force-pushed the add-version-to-add-lines-requires branch from 24b10a8 to 3319fcf Compare May 29, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HypeMC