Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to skip package.json synchronization #1032

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

wuchen90
Copy link

For those who doesn't want the package.json synchronization, this PR offers to opt-out this behavior by setting the config below in extra section of composer.json:

{
  "extra": {
    "symfony/flex": {
      "synchronize_package_json": false
    }
  }
}

fix #1017

@wuchen90 wuchen90 force-pushed the skip-package-json-sync branch from 9b8e4cb to 6a726fa Compare November 29, 2024 17:48
Copy link
Contributor

@skmedix skmedix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps it would be better if it logs what exactly has been skipped?

@wuchen90
Copy link
Author

Perhaps it would be better if it logs what exactly has been skipped?

@skmedix Currently it already outputs this <info>Skip synchronizing package.json with PHP packages</>. What kind of logs do you have in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make packages.json synchronization optional
2 participants