[AssetMapper] Allow to define entrypoint in importmap.php #1026
Conversation
|
relate to symfony/symfony#53912 |
| @@ -267,8 +268,14 @@ private function updateImportMap(array $importMapEntries): void | |||
| $this->io->writeError(sprintf('Updating package <comment>%s</> from <info>%s</> to <info>%s</>.', $name, $version, $versionConstraint)); | |||
| } | |||
|
|
|||
| $arguments = []; | |||
There was a problem hiding this comment.
A package with version cannot be an entrypoint... so entrypoints should not be concerned here, no ?
There was a problem hiding this comment.
Yeah, i see what you mean.
If i remember correctly, it was to avoid too many if levels but I can add it inside the following condition
|
Do we allow bundle to change the public/index.php file? Or to create new webpack configs ? I really find weird that a bundle could install things like this. And a bit dangerous. And still wait for a use case that require to create a entrypoint .... maybe you could describe yours for the package in question ? That really could help me understand the need. |
| @@ -147,7 +147,7 @@ private function resolveImportMapPackages($phpPackage): array | |||
| } | |||
|
|
|||
| $dependencies = []; | |||
|
|
|||
| $entrypoints = $packageJson->read()['symfony']['entrypoints'] ?? []; | |||
There was a problem hiding this comment.
Took some time to refresh my memory and re-read all this code 😅
So .. nope : this is not related to importmap entrypoints, but to stimulus bundle + controllers.json file. Thus should not be used here :)
Should not be used here
| $dependencies[$importMapName] = [ | ||
| 'path' => $path, | ||
| 'entrypoint' => \in_array($importMapName, $entrypoints, true), | ||
| ]; |
There was a problem hiding this comment.
By definition, a dependency cannot be an importmap entrypoint :)
Hello 👋
I wanted that one of my package to be able to define an asset as entrypoint inside importmap.php to be allow call
importmap('@mypackage/entry.js')inside a template of the package.I made a naive modification, not sure if it was the purpose of the
[symfony][entrypoints]node of the package.json.Maybe it would be fit directly inside the
[symfony][importmap]node.WDYT ?