Tweak versioning and return back failing on CI #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, still does not work, probably the problem is in something else, depends on how that "hash" is generated, because when I manually change the full path to the repo locally - it still works for me. Closing it |
|
@bocharsky-bw would this be fixed (or would it simplify the solution) if we disable versioning? I think we can do that for this demo app. |
|
Hm, if we could consider disabling versioning on this app - I think it might help then. Let's figure it out |
bocharsky-bw
changed the title
|
OK, this looks like a working example based on TravisCI |
Merged
bocharsky-bw
changed the title
|
I think this one is ready |
javiereguiluz
force-pushed
the
tweak-versioning
branch
from
6be5e70 to
5fcb943
Compare
|
Thanks Victor for working on this feature, this is much appreciated. |
javiereguiluz
added a commit
that referenced
this pull request
Jun 25, 2019
…ky-bw) This PR was squashed before being merged into the master branch (closes #1004). Discussion ---------- Tweak versioning and return back failing on CI A possible fix for: #994 (comment) Commits ------- 5fcb943 Tweak versioning and return back failing on CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A possible fix for: #994 (comment)