-
-
Notifications
You must be signed in to change notification settings - Fork 36
[AIBundle] Simplify agent-as-tool configuration #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+62
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f3892a
to
02290d4
Compare
chr-hertel
reviewed
Jul 20, 2025
chr-hertel
reviewed
Jul 20, 2025
needs a rebase |
02290d4
to
4178801
Compare
OskarStark
approved these changes
Jul 21, 2025
Can you please add a test case for the DI config? Thanks |
e66e31e
to
72886d2
Compare
72886d2
to
e8b7b22
Compare
Ok, should be good now |
OskarStark
approved these changes
Jul 21, 2025
chr-hertel
approved these changes
Jul 21, 2025
Thank you @valtzu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify agent as tool setup:
agent: name
instead ofis_agent: true, service: ai.agent.name
agent
as fallback forname
This is a BC break, but if we wanted to, we could keep
is_agent
around and have the new way only as shortcut.