Skip to content

[AIBundle] Simplify agent-as-tool configuration #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

[AIBundle] Simplify agent-as-tool configuration #175

merged 1 commit into from
Jul 21, 2025
+62 −10

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Jul 20, 2025 •
edited
Loading

Q A
Bug fix? no
New feature? yes, kinda
Docs? yes, adjusted
Issues Fix #172
License MIT

Simplify agent as tool setup:

  1. Set agent: name instead of is_agent: true, service: ai.agent.name
  2. Use agent as fallback for name

This is a BC break, but if we wanted to, we could keep is_agent around and have the new way only as shortcut.

@valtzu valtzu force-pushed the simplify-agent-as-tool-config branch from 1f3892a to 02290d4 Compare July 20, 2025 19:22
@chr-hertel chr-hertel added the AI Bundle Issues & PRs about the AI integration bundle label Jul 20, 2025
chr-hertel
chr-hertel reviewed Jul 20, 2025
View reviewed changes
chr-hertel
chr-hertel reviewed Jul 20, 2025
View reviewed changes
@chr-hertel
Copy link
Contributor

chr-hertel commented Jul 20, 2025 •
edited
Loading

needs a rebase

@valtzu valtzu force-pushed the simplify-agent-as-tool-config branch from 02290d4 to 4178801 Compare July 20, 2025 22:52
@OskarStark
Copy link
Contributor

Can you please add a test case for the DI config? Thanks

@valtzu valtzu force-pushed the simplify-agent-as-tool-config branch 3 times, most recently from e66e31e to 72886d2 Compare July 21, 2025 11:15
@valtzu valtzu force-pushed the simplify-agent-as-tool-config branch from 72886d2 to e8b7b22 Compare July 21, 2025 11:22
@valtzu
Copy link
Contributor Author

valtzu commented Jul 21, 2025

Ok, should be good now

@OskarStark OskarStark requested a review from chr-hertel July 21, 2025 11:33
@chr-hertel
Copy link
Contributor

Thank you @valtzu.

@chr-hertel chr-hertel merged commit a32efc3 into symfony:main Jul 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@chr-hertel chr-hertel chr-hertel approved these changes

@Nyholm Nyholm Awaiting requested review from Nyholm Nyholm is a code owner

Assignees
No one assigned
Labels
AI Bundle Issues & PRs about the AI integration bundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AIBundle] Simplify agent-as-tool configuration
3 participants
@valtzu @chr-hertel @OskarStark