Skip to content

chore(documentation): minor update for post-popover #5501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

myrta2302
Copy link
Contributor

@myrta2302 myrta2302 commented May 15, 2025

πŸ“„ Description

  • Popover: Added missing close-button-caption attribute

πŸ“ Checklist

  • βœ… My code follows the style guidelines of this project
  • πŸ› οΈ I have performed a self-review of my own code
  • πŸ“„ I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • βœ”οΈ New and existing unit tests pass locally with my changes

@myrta2302 myrta2302 requested review from a team as code owners May 15, 2025 07:11
@myrta2302 myrta2302 requested a review from alizedebray May 15, 2025 07:11
Copy link

changeset-bot bot commented May 15, 2025

πŸ¦‹ Changeset detected

Latest commit: 88b9211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@myrta2302 myrta2302 requested review from alionazherdetska and removed request for alizedebray May 15, 2025 07:11
@myrta2302 myrta2302 changed the title Chore(documentation) minor updates for post back to top and post popover chore(documentation): minor updates for post-back-to-top and post-popover May 15, 2025
@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 15, 2025

Related Previews

Copy link

@myrta2302 myrta2302 changed the title chore(documentation): minor updates for post-back-to-top and post-popover chore(documentation): minor update for post-popover May 16, 2025
'@swisspost/design-system-documentation': patch
---

Added `close-button-caption` attribute in `post-popover` component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Added `close-button-caption` attribute in `post-popover` component.
Updated `post-popover` component documentation by adding missing `close-button-caption` attribute in component examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants