Skip to content

fix(component): fix animation error in post-collapsible when inside inactive tabs #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alionazherdetska
Copy link
Contributor

@alionazherdetska alionazherdetska commented May 8, 2025

📄 Description

This PR adds visibility check before committing animation styles in PostCollapsible.toggle() to prevent InvalidStateError when the target element is hidden. This resolves errors occurring when animating elements inside hidden tab panels.


📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alionazherdetska alionazherdetska requested a review from a team as a code owner May 8, 2025 16:46
@alionazherdetska alionazherdetska added the on hold Wait for something to be done, before continue working on this Issue label May 8, 2025
@alionazherdetska alionazherdetska requested review from leagrdv and removed request for a team May 8, 2025 16:46
Copy link

changeset-bot bot commented May 8, 2025

⚠️ No Changeset found

Latest commit: 1354018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 8, 2025

Related Previews

Copy link

sonarqubecloud bot commented May 8, 2025

@alionazherdetska alionazherdetska changed the title fix(component): fix animation error in post-collapsible when inside inactive tabs fix(component): fix animation error in post-collapsible when inside inactive tabs May 8, 2025
@alionazherdetska
Copy link
Contributor Author

alionazherdetska commented May 15, 2025

Closed this PR since I could not add a changeset and was receiving an error. Opened a new PR to address the ticket #5502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Wait for something to be done, before continue working on this Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants