Skip to content

feat(styles, components): target group html/css component #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented May 5, 2025

πŸ“„ Description

This PR adds the target group html/css component with its documentation.

πŸš€ Demo

If applicable, please add a screenshot or video to illustrate the changes.


πŸ“ Checklist

  • βœ… My code follows the style guidelines of this project
  • πŸ› οΈ I have performed a self-review of my own code
  • πŸ“„ I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • πŸ§ͺ I have added tests that prove my fix is effective or that my feature works
  • βœ”οΈ New and existing unit tests pass locally with my changes

@leagrdv leagrdv requested review from a team as code owners May 5, 2025 12:49
@leagrdv leagrdv linked an issue May 5, 2025 that may be closed by this pull request
5 tasks
@leagrdv leagrdv requested a review from oliverschuerch May 5, 2025 12:49
Copy link

changeset-bot bot commented May 5, 2025

πŸ¦‹ Changeset detected

Latest commit: cb2c49b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-components Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/internet-header Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 5, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
design-system-documentation βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 5, 2025 1:51pm

@swisspost-bot
Copy link
Contributor

swisspost-bot commented May 5, 2025

Related Previews

Copy link
Contributor

@oliverschuerch oliverschuerch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this component is adding styles specially meant to work when used in the post-header (at least on mobile devices), we should document it under "raw-components" in my opinion.

Or as an alternative, we should move some header specific styles (e.g. padding) to the post-header component.

@leagrdv leagrdv requested a review from oliverschuerch May 9, 2025 06:13
Copy link

sonarqubecloud bot commented May 9, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[html/css] Target Group
3 participants