Skip to content

chore(docs): include raw-components and health stories in the local build #5377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

schaertim
Copy link
Contributor

@schaertim schaertim commented Apr 30, 2025

📄 Description

Some of the stories should only be shown when the docs are run locally. Up to now, they were just hidden from the navigation sidebar using css. That meant they could still be found and accessed by searching for them in the searchbar.
As a more robust solution instead of just hiding them with css i added logic to not include them in the build at all if we are not in the dev environment.

🚀 Demo

If applicable, please add a screenshot or video to illustrate the changes.


📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@schaertim schaertim linked an issue Apr 30, 2025 that may be closed by this pull request
Copy link

vercel bot commented Apr 30, 2025

You must have Developer access to commit code to Swiss Post on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

Copy link

changeset-bot bot commented Apr 30, 2025

🦋 Changeset detected

Latest commit: c78ddc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-documentation Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 30, 2025

Related Previews

@schaertim schaertim marked this pull request as ready for review May 6, 2025 11:03
@schaertim schaertim requested review from a team as code owners May 6, 2025 11:03
@schaertim schaertim requested a review from oliverschuerch May 6, 2025 11:03
@schaertim schaertim requested review from oliverschuerch and removed request for oliverschuerch May 7, 2025 07:50
@schaertim schaertim requested a review from oliverschuerch May 7, 2025 08:32
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Storybook can search through hidden components
3 participants