Skip to content

test(documentation): added basic e2e tests for the new palette implementation #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: feat/tokens-integration-test
Choose a base branch
from

Conversation

oliverschuerch
Copy link
Contributor

📄 Description

This PR implements some basic e2e test for the new palettes integration.
However, they are not complete, but are meant to stabilize the current implementation so that we can figure out if anything goes horribly wrong during further development.


📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@oliverschuerch oliverschuerch added the 🚂 PR train PR which follows another one. label Apr 23, 2025
@oliverschuerch oliverschuerch requested review from a team as code owners April 23, 2025 14:56
@oliverschuerch oliverschuerch requested review from gfellerph and removed request for a team April 23, 2025 14:56
Copy link

changeset-bot bot commented Apr 23, 2025

⚠️ No Changeset found

Latest commit: 9dab7c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Apr 23, 2025

Related Previews

@gfellerph gfellerph requested review from alizedebray and removed request for gfellerph May 8, 2025 12:50
@@ -1 +1,3 @@
<script src="/assets/scripts/storybook-preview-events.js"></script>
<body data-color-scheme="light">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

light dark should be the default without having the specify a data-color-scheme attribute. Do you know why it is necessary here?

scheme => html` <div data-color-scheme="${scheme}" class="p-16 palette-default">
${renderFn(scheme)}
</div>`,
scheme => html` <div data-color-scheme="${scheme}" class="p-16">${renderFn(scheme)}</div>`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to test how the palettes behave without a defined data-color-scheme, I have seen this article about dark mode in Cypress: https://www.cypress.io/blog/test-your-web-app-in-dark-mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚂 PR train PR which follows another one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants