-
Notifications
You must be signed in to change notification settings - Fork 18
test(documentation): added basic e2e tests for the new palette implementation #5338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/tokens-integration-test
Are you sure you want to change the base?
test(documentation): added basic e2e tests for the new palette implementation #5338
Conversation
|
|
Related Previews |
@@ -1 +1,3 @@ | |||
<script src="/assets/scripts/storybook-preview-events.js"></script> | |||
<body data-color-scheme="light"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
light dark
should be the default without having the specify a data-color-scheme
attribute. Do you know why it is necessary here?
scheme => html` <div data-color-scheme="${scheme}" class="p-16 palette-default"> | ||
${renderFn(scheme)} | ||
</div>`, | ||
scheme => html` <div data-color-scheme="${scheme}" class="p-16">${renderFn(scheme)}</div>`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to test how the palettes behave without a defined data-color-scheme
, I have seen this article about dark mode in Cypress: https://www.cypress.io/blog/test-your-web-app-in-dark-mode
📄 Description
This PR implements some basic e2e test for the new palettes integration.
However, they are not complete, but are meant to stabilize the current implementation so that we can figure out if anything goes horribly wrong during further development.
📝 Checklist