Conversation
…dAuthority and updated the test schema according to the new fixture data
StanH-Swis
approved these changes
Aug 18, 2025
JaZo
reviewed
Sep 1, 2025
| self::Event => 'Evenement', | ||
| self::Waterway => 'Vaarweg werk', | ||
| self::WaterwayEvent => 'Vaarweg evenement', | ||
| self::Railway => 'Spoorweg', |
| "type": "object", | ||
| "additionalProperties": false, | ||
| "properties": { | ||
| "recordId": { |
Member
There was a problem hiding this comment.
This isn't allowed according to the GeoJSON spec. Is this correct? 🤔
| "type": { | ||
| "$ref": "#/definitions/GeometryType" | ||
| }, | ||
| "crs": { |
Member
There was a problem hiding this comment.
This is incorrect, this is how it's present in the API (and the GeoJSON-spec):
"crs": {
"type": "name",
"properties": {
"name": "EPSG:4326"
}
},According to this schema, it should be something like this:
"crs": {
"name": "EPSG:4326"
},
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added railway as an activityType, added cbsCode attribute to RoadAuthority and updated the test schema according to the new fixture data
Description
The activity type now has a railway value, roadAuthority now has a cbs code attribute which can be null and the geometry of a situation now includes the crs data.
Motivation and context
The tests where failing in the pipeline due to changes made in their API, also the schema was not matching the updated fixtures
If it fixes an open issue, please link to the issue here (if you write
fixes #numor
closes #num, the issue will be automatically closed when the pull is accepted.)How has this been tested?
I made sure i had fully updated the fixtures so that i had the most recent testdata. After this i ran the situationsTest locally to verify my schema changes matches the testdata.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
If you're unsure about any of these, don't hesitate to ask. We're here to help!