Fix/contact and person attributes can be null#12
Merged
Conversation
added 2 commits
August 14, 2025 14:37
… is always there, also remarks can be null
StanH-Swis
approved these changes
Aug 14, 2025
JaZo
reviewed
Sep 1, 2025
| ($object->properties->permitId ?? '') ?: null, | ||
| ($object->properties->referenceId ?? '') ?: null, | ||
| $object->properties->remarks, | ||
| ($object->properties->remarks ?? '') ?: null, |
Member
There was a problem hiding this comment.
This property is an array, so a fallback to an empty string is a little odd here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The NDW have performed critical changes in their API. a lot of contact attributes are now nullable, also the prefix attribute of a person can now be null. The same goes for remarks.
The above information has been verified by the NDW
Motivation and context
The package crashes now when trying to import Melvin data, since these fields are in almost every situation, its critical that this is resolved quickly.
If it fixes an open issue, please link to the issue here (if you write
fixes #numor
closes #num, the issue will be automatically closed when the pull is accepted.)How has this been tested?
I have ran a test importing the data. Alot of situations had null values for the above fields
Running the integration tests will show that it now works again
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.
If you're unsure about any of these, don't hesitate to ask. We're here to help!