Skip to content

Conversation

@kedij777
Copy link

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Issue #1916

What is the new behavior?
When the mouse is not hovered over the line chart x-axis node, the pie chart displays the sum of the values for each legend group. When the mouse is over one of the x-axis nodes of the line chart, the pie chart shows the distribution of y-values for each country at that x-value.
demo1

The combo chart supports all reasonable features of line chart and pie chart respectively.
demo2

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@kedij777 kedij777 marked this pull request as draft November 29, 2023 02:03
@kedij777 kedij777 marked this pull request as ready for review December 3, 2023 20:22
@kedij777 kedij777 changed the title Added Line-Pie Combo Chart New Line-Pie Combo Chart Dec 3, 2023
@Lyq322
Copy link

Lyq322 commented Dec 24, 2023

Initial pie chart does not change when real-time data is enabled. Only the line chart data changes
Before enabling real-time data:
Screenshot 2023-12-24 at 12 48 59 PM
After enabling: pie chart data does not update
Screenshot 2023-12-24 at 12 50 03 PM

@Lyq322
Copy link

Lyq322 commented Dec 24, 2023

Unclear which data is for pie chart and which is for line chart.
Screenshot 2023-12-24 at 12 53 10 PM

@Lyq322
Copy link

Lyq322 commented Dec 24, 2023

Fit container does not work. Dimensions were not changed after enabling fit container.
After enabling fit container:
Screenshot 2023-12-24 at 12 54 51 PM

@Lyq322
Copy link

Lyq322 commented Dec 24, 2023

Currently, it seems that the two charts are separated by a fixed distance. This causes the pie and line charts to be too far apart when the dimensions are small and too close together when the dimensions are large.
Screenshot 2023-12-24 at 1 05 34 PM
Screenshot 2023-12-24 at 1 05 53 PM

@kedij777
Copy link
Author

kedij777 commented Jan 8, 2024

Unclear which data is for pie chart and which is for line chart. Screenshot 2023-12-24 at 12 53 10 PM

Thanks for suggestion, fixed.
image

@kedij777 kedij777 closed this Jan 8, 2024
@kedij777 kedij777 reopened this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants