GDB RP: handle instruction stepping debugger host command #215
+125
−38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements
vCont;sdebugger host command, which allows stepping over Wasm instructions.This required fixing an off-by-one error in instruction mapping search logic, with new test expectations added in
DebuggerTests/binarySearchfunction.Note that this doesn't handle branching instructions yet, we just increment Pc by one instruction without proper analysis of potential branching (marked as
TODO).Corresponding test expectations for the debugger breakpoints and stepping are added in
DebuggerTests/breakpoints(previously calledDebuggerTests/stopAtEntrypoint).