Skip to content

Conversation

award999
Copy link
Contributor

@award999 award999 commented Jul 29, 2025

Description

  • Bump the extension version so targeting next release version, adding -dev to distinguish
  • Decrement pre-release minor version since manifest will now have the next, not current version
  • Allow -dev in vsix file name when downloading vsix for tests
  • When downloading VSIX, add the actual file name to GITHUB_ENV, without renaming
  • Determine version from the VSIX filename or fallback to the package.json version
  • Realized that in CI the VSIX was NOT being used for linux runs so fixed this and:
  • skipExtensionDependencies in CI
  • The RUNNING_IN_CI does not work so introduce new logic to check if source is being run as part of the test CLI instead
    • Make "VSCODE_TEST" env var longer so harder to accidentally set

Issue: N/A

Tasks

  • Required tests have been written
  • Documentation has been updated
  • Added an entry to CHANGELOG.md if applicable

@award999 award999 force-pushed the bump-version branch 8 times, most recently from b349141 to 42f7ce3 Compare July 30, 2025 18:39
@award999 award999 force-pushed the bump-version branch 2 times, most recently from 3ff84f3 to 90ba7d4 Compare July 31, 2025 18:36
@award999 award999 added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label Jul 31, 2025
@award999 award999 force-pushed the bump-version branch 3 times, most recently from be1651c to cd59bc5 Compare August 1, 2025 16:43
@award999 award999 marked this pull request as ready for review August 1, 2025 17:36
@award999
Copy link
Contributor Author

award999 commented Aug 1, 2025

The full nightly run also passed on my fork's action https://github.com/award999/vscode-swift/actions/runs/16681615407

@award999 award999 merged commit c198a25 into swiftlang:main Aug 5, 2025
35 of 36 checks passed
@award999 award999 deleted the bump-version branch August 5, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants