Skip to content

Better handle status updates for build tasks #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewbastien merged 2 commits into from
May 21, 2025
Merged

Better handle status updates for build tasks #1539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31dbbd2
Better handle status updates for build tasks
award999 May 6, 2025
83e1cd4
Remove && true
award999 May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ui/SwiftBuildStatus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export class SwiftBuildStatus implements vscode.Disposable {
}

const execution = task.execution as SwiftExecution;
const isBuildTask = task.group === vscode.TaskGroup.Build;
const disposables: vscode.Disposable[] = [];
const handleTaskOutput = (update: (message: string) => void) =>
new Promise<void>(res => {
Expand All @@ -75,6 +76,7 @@ export class SwiftBuildStatus implements vscode.Disposable {
this.outputParser(
new RunningTask(task).name,
execution,
isBuildTask,
showBuildStatus,
update,
done
Expand Down Expand Up @@ -107,6 +109,7 @@ export class SwiftBuildStatus implements vscode.Disposable {
private outputParser(
name: string,
execution: SwiftExecution,
isBuildTask: boolean,
showBuildStatus: ShowBuildStatusOptions,
update: (message: string) => void,
done: () => void
Expand All @@ -121,7 +124,8 @@ export class SwiftBuildStatus implements vscode.Disposable {
const lines = sanitizedData.split(/\r\n|\n|\r/gm).reverse();
for (const line of lines) {
if (checkIfBuildComplete(line)) {
return true;
update(name);
return !isBuildTask;
}
const progress = this.findBuildProgress(line);
if (progress) {
Expand Down