Reapply #87698 and fix overload resolution for Sequence+AsyncSequence types.#88442
Open
clintonpi wants to merge 2 commits intoswiftlang:mainfrom
Open
Reapply #87698 and fix overload resolution for Sequence+AsyncSequence types.#88442clintonpi wants to merge 2 commits intoswiftlang:mainfrom
clintonpi wants to merge 2 commits intoswiftlang:mainfrom
Conversation
…wiftlang#87698)" (swiftlang#88269) This reverts commit 8a51f7a.
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test source compatibility |
Since generalizing Sequence methods for typed throws, the overload resolution prefers the corresponding AsyncSequence methods which cannot be generalized yet. To fix this, all rethrowing Sequence methods (except withContiguousStorageIfAvailable) were duplicated in a new extension (`extension AsyncSequence where Self: Sequence`).
clintonpi
force-pushed
the
async-sequence-typed-throws-generalization
branch
from
fd496a6 to
c3e2873
Compare
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please test source compatibility |
phausler
approved these changes
Apr 13, 2026
Contributor
phausler
left a comment
phausler
left a comment
There was a problem hiding this comment.
This approach looks good; what does it mean for when we do further typed throws support for async sequence?
Contributor
Author
|
If the support is back-deployed covering SwiftStdlib 5.1, then these duplicates can be safely deleted with no source breakage. Else, they'll have to stay in place and be annotated as obsolete. |
Contributor
Author
|
Also, if the duplicates were somehow forgotten and co-exist with the future AsyncSequence typed-throwing methods, other things being equal, the future typed-throwing ones will be picked where the current rethrowing ones are picked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since generalizing Sequence methods for typed throws, the overload resolution prefers the corresponding AsyncSequence methods which cannot be generalized yet. To fix this, all rethrowing Sequence methods (except withContiguousStorageIfAvailable) were duplicated in a new extension (
extension AsyncSequence where Self: Sequence).