[Diagnostics] Replace diagnostics' DefaultIgnore option with a corresponding option on diagnostic groups
#85098
+217
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
DougGregor,
hborla,
slavapestov,
tshortli and
xedin
as code owners
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
from
e44c07f to
5395e8b
Compare
|
@swift-ci test |
tshortli
approved these changes
Oct 23, 2025
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
from
5395e8b to
83eea39
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
3 times, most recently
from
51c5d05 to
9e9d91b
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
from
9e9d91b to
79e3542
Compare
|
@swift-ci smoke test |
jamieQ
reviewed
Oct 29, 2025
|
|
||
| /// The diagnostic warnings belonging to this group should be ignored by default, | ||
| /// but will be re-enabled by various warning options (-Wwarning, -Werror). | ||
| DefaultIgnoreWarnings, |
There was a problem hiding this comment.
out of curiosity, is functionality like this expected to remain 'one way'? i.e. you can go from ignored to not, but you can't go back.
There was a problem hiding this comment.
That's right; but, we're building towards a way to go in the other direction with source-level controls:
https://forums.swift.org/t/pitch-source-level-control-over-compiler-warnings/
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
from
79e3542 to
f2ac958
Compare
|
@swift-ci smoke test |
…esponding option on diagnostic groups This brings this control in line with other diagnostic controls we have which operate on a per-group level. 'DefaultIgnoreWarnings' diagnostic group option applies to all warnings belonging to a certain diagnostic group. The inheritance rules are: - Marking a diagnostic group as 'DefaultIgnoreWarnings' means warnings belonging to this group will not be emitted by-default - Warnings belonging to sub-groups of this group will also not be emitted by-default - Enabling a 'DefaultIgnoreWarnings' group (with '-Werror','-Wwarning', etc.) means warnings belonging to this group will be emitted. - Warnings belonging to sub-groups of this group will also be emitted. - Warnings belonging to super-groups of this group will not be affected.
artemcm
force-pushed
the
DefaultIgnoreDiagnosticGroups
branch
from
f2ac958 to
9e35f82
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings this control in line with other diagnostic controls we have which operate on a per-group level.
DefaultIgnoreWarningsdiagnostic group option applies to all warnings belonging to a certain diagnostic group.The inheritance rules are:
DefaultIgnoreWarningsmeans warnings belonging to this group will not be emitted by-defaultDefaultIgnoreWarningsgroup (with-Werror,-Wwarning, etc.) means warnings belonging to this group will be emitted.