build.ps1: add swift-tools-protocols #85078
Conversation
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
2e16a23 to
2857499
Compare
|
swiftlang/sourcekit-lsp#2324 |
2 similar comments
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
utils/build.ps1
Outdated
| -SwiftSDK $SDKROOT ` | ||
| -BuildTargets default ` | ||
| -Defines @{ | ||
| BUILD_SHARED_LIBS = "NO"; |
There was a problem hiding this comment.
Is this a single use library? i.e. does only one product use the library? If not, we should consider the shared version with numbers on the size impact - that is verify that static linking is smaller than the dynamic linking.
There was a problem hiding this comment.
It's going to get linked into at least two executables, so I will probably end up flipping it to a shared library but I haven't tested it yet
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
2857499 to
57a58c7
Compare
|
swiftlang/sourcekit-lsp#2324 |
4 similar comments
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
57a58c7 to
bdcd59d
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
bdcd59d to
a4ac2dc
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
a4ac2dc to
8876942
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
8876942 to
5d351dd
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
5d351dd to
642d724
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
642d724 to
220b235
Compare
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
220b235 to
87ea24c
Compare
|
swiftlang/sourcekit-lsp#2324 |
1 similar comment
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
87ea24c to
1c299c5
Compare
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
3 times, most recently
from
da862c6 to
5f253a7
Compare
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
2 times, most recently
from
a6399dc to
e5ae3c2
Compare
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
e5ae3c2 to
c165f77
Compare
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
c165f77 to
2c58e28
Compare
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
|
@swift-ci please build toolchain Windows ARM64 platform |
|
Toolchain & test builds are all passing. I have a handful more review comments to address on the sourcekit-lsp side, then I'll look at re-running the builds and landing this |
owenv
force-pushed
the
owenv/tools-protocols-windows
branch
from
2c58e28 to
c12d5a7
Compare
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
|
@shahmishal fyi this does include an update-checkout version bump for swift-tools-protocols |
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
2 participants
This will be a sourcekit-lsp dependency starting with swiftlang/sourcekit-lsp#2324, a SwiftPM dependency starting with swiftlang/swift-package-manager#9129, and a swift-build dependency starting with swiftlang/swift-build#782. Update the windows build script accordingly