Skip to content

[Concurrency] Use ASSERT for to also assert in release builds #82865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

[Concurrency] Use ASSERT for to also assert in release builds #82865

merged 1 commit into from
Jul 8, 2025
+1 −1

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Jul 8, 2025 •
edited
Loading

Small cleanup from code review; we'd crash either way after this line, so might be better to always ASSERT more nicely.

Thanks for pointing that out @slavapestov in #82826

@ktoso
[Concurrency] Use ASSERT for to also assert in release builds
4a5ccf0 
Small cleanup from code review; we'd crash either way after this line,
so might be better to always ASSERT more nicely.
@ktoso ktoso requested a review from jckarter as a code owner July 8, 2025 01:05
@ktoso
Copy link
Contributor Author

ktoso commented Jul 8, 2025

@swift-ci please smoke test

@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label Jul 8, 2025
@ktoso ktoso enabled auto-merge July 8, 2025 01:21
@ktoso ktoso merged commit e9a35c0 into swiftlang:main Jul 8, 2025
3 checks passed
@ktoso ktoso deleted the wip-stronger-assert branch July 8, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

Assignees
No one assigned
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ktoso