[cxx-interop] Test std::optional with AddressableParameters
#82809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling AddressableParameters feature resolves a miscompile with `var pointee` properties of `std::optional`. rdar://154945438 / #82765
If we could not infer lifetime dependencies for a C++ method, let's cache the empty result. This prevents the compiler from trying to evaluate this request using Swift Sema's algorithm. This change is meant to fix the following issue: With AddressableParameters enabled, instantiations of `std::optional<T>` lack the conformance to `protocol CxxOptional`, despite the synthesized conformance being added correctly to each instantiation. This happens because when importing `operator*()` of each instantiation, ClangImporter spins up a LifetimeDependenceInfoRequest for the incompletely imported C++ type. In particular, the synthesized protocol conformances aren't yet added at that point, since the conformance logic relies on type's members already being imported. The LifetimeDependenceInfoRequest triggers a ConformanceTable to be built and cached for the instantiation. Later, by the time the conformance synthesis logic runs, the ConformanceTable for the instantiation had already been populated, and won't be updated to add the new conformance.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see each commit for details.