[6.2] LetPropertyLowering: remove redundant phis after ssa-update #82808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jul 4, 2025
eeckstein
commented
- Explanation: Fixes a SIL ownership verifier error. This fixes an old bug, which is now surfaced because we do ownership verification also in a non-assert compiler. The fix is to run a peephole transformation in the LetPropertyLowering pass, as we do in LoopRotate, where we had the same problem.
- Risk: Low. It's a simple fix which runs a peephole transformation which already runs (and is tested in) LoopRotate.
- Testing: Tested by lit tests.
- Issue: rdar://153229472
- Reviewer: @nate-chandler
- Main branch PR: LetPropertyLowering: remove redundant phis after ssa-update #82798
This is needed after running the SSAUpdater, because the updater can insert unnecessary phis in the middle of the original liverange of a value. Fixes an ownership error. rdar://153229472
|
@swift-ci test |
tbkka
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.