Implement reflection support for Symbolic Extended Existential types. #82389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-prantl
force-pushed
the
153934495
branch
2 times, most recently
from
7966da9 to
399dd19
Compare
adrian-prantl
changed the title
|
@swift-ci test with swiftlang/llvm-project#10915 |
|
test with swiftlang/llvm-project#10915 |
adrian-prantl
commented
Jun 27, 2025
adrian-prantl
commented
Jun 30, 2025
adrian-prantl
commented
Jun 30, 2025
adrian-prantl
commented
Jun 30, 2025
|
test with swiftlang/llvm-project#10915 |
|
test with swiftlang/llvm-project#10915 |
|
test with swiftlang/llvm-project#10915 |
rjmccall
reviewed
Jul 2, 2025
| /*nullable*/ false>; | ||
| constexpr size_t buffer_size = sizeof(ExtendedExistentialTypeShapeFlags) + | ||
| sizeof(RelativeOffset) + | ||
| sizeof(GenericContextDescriptorHeader); |
There was a problem hiding this comment.
Please try:
union {
TargetExtendedExistentialTypeShape<Runtime> shapeHeader;
};
if (!Reader->readBytes(RemoteAddress(address), reinterpret_cast<uint8_t*>(&shapeHeader), sizeof(shapeHeader))
return nullptr;
and then you should be able to just use shapeHeader.Flags and shapeHeader.ReqSigHeader without any other fuss.
There was a problem hiding this comment.
That didn't work directly because TargetExtendedExistentialTypeShape has no default constructor, but I updated the patch to do achieve something pretty close.
This patch adds a new SymbolicExtendedExistentialTypeRef kind, and wires it up in TypeDecoder, TypeRefBuilder, TypeLowering, and ASTDemangler. This is tested indirectly via the matching LLDB commit.
|
test with swiftlang/llvm-project#10915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch add a new SymbolicExtendedExistentialTypeRef kind wires it up in TypeDecoder, TypeRefBuilder, TypeLowering, and ASTDemangler. This is tested indirectly via the matching LLDB commit.
EDIT: This is now ready for review!