Skip to content

Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243"#81658

Merged
qiongsiwu merged 1 commit intoswiftlang:mainfrom
qiongsiwu:revert_144794793
Jun 9, 2025
Merged

Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243"#81658
qiongsiwu merged 1 commit intoswiftlang:mainfrom
qiongsiwu:revert_144794793

Conversation

@qiongsiwu
Copy link
Copy Markdown
Contributor

This reverts commit 024dbd0, reversing changes made to a08b1cb.

The commit did not solve the fundamental issue we need to handle and is no longer necessary.

rdar://144794793

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

qiongsiwu commented May 21, 2025

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@cyndyishida
Copy link
Copy Markdown
Contributor

Can you update the commit title to say "Revert [Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps"
Otherwise, it's harder to tell from a condensed git log what the commit is doing.

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

@qiongsiwu qiongsiwu changed the title Revert "Merge pull request #81243 from qiongsiwu/eng_144794793" Revert "[Dependency Scanning] Update Uses of ModuleDeps::ClangModuleDeps #81243" May 21, 2025
@qiongsiwu
Copy link
Copy Markdown
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

The previous test failure should be fixed by #81666.

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

swiftlang/llvm-project#10717
@swift-ci smoke test

@qiongsiwu
Copy link
Copy Markdown
Contributor Author

@qiongsiwu qiongsiwu merged commit 1b003b2 into swiftlang:main Jun 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants