Skip to content

Add a test for property access on ~Escapable types #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: jgrynspan/162-redesign-value-capture
Choose a base branch
from
Open

Add a test for property access on ~Escapable types #1155

wants to merge 1 commit into from

Conversation

@natecook1000
Copy link
Member

This tests using a ~Escapable type as the LHS of a property access inside the #expect and #require macros. A ~Escapable return value from #require is unsupported.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@natecook1000
Add a test for property access on ~Escapable types
2142139 
This tests using a ~Escapable type as the LHS of a property access
inside the `#expect` and `#require` macros. A ~Escapable return value
from `#require` is unsupported.
@stmontgomery
Copy link
Contributor

@swift-ci please test

@stmontgomery stmontgomery added enhancement New feature or request macros 🔭 Related to Swift macros such as @Test or #expect labels Jun 13, 2025
@stmontgomery stmontgomery added this to the Swift 6.x milestone Jun 13, 2025
@grynspan
Copy link
Contributor

I believe this test is dependent on #840, right?

@natecook1000
Copy link
Member Author

Right! I believe it's aimed at that branch, not main. Should I direct it somewhere else?

@grynspan
Copy link
Contributor

grynspan commented Jul 9, 2025

Nope, just confirming the dependency is why the test failed. You could redirect the PR to merge to that branch, and then it would pass?

@grynspan
Copy link
Contributor

grynspan commented Jul 9, 2025

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@grynspan grynspan Awaiting requested review from grynspan grynspan is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

No one assigned

Labels

enhancement New feature or request macros 🔭 Related to Swift macros such as @Test or #expect

Projects

None yet

Milestone

Swift 6.x (main)

Development

Successfully merging this pull request may close these issues.

3 participants

@natecook1000 @stmontgomery @grynspan