generator/linux: Use --ldpath linker flag for 5.9
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
euanh
commented
Nov 18, 2024
| "-Xlinker", | ||
| "-R/usr/lib/swift/linux/", | ||
| ]) | ||
| var swiftCompilerOptions = ["-Xlinker", "-R/usr/lib/swift/linux/"] |
There was a problem hiding this comment.
I think -Xlinker -R/usr/lib/swift/linux/ may not be necessary any more, but want to do more testing before removing it.
Swift Package Manager's linker flag handling changed between 5.9 and 5.10. The flags which work for 5.9 cause linking failures 5.10 and later, and vice versa: swiftlang/swift-package-manager#7222 This commit generates workaround flags for 5.9 and new-style flags for all other versions. The EndToEnd tests currently cannot run in CI, so this change was tested locally. (Issue swiftlang#145) * The basic 'hello world' example generated by `swift package init` built successfully with 5.9.2, 5.10.1 and 6.0.2 SDKs on x86_64 and aarch64. * A more complex example using Vapor built succesfully with 5.9.2, 5.10.1. 6.0.2 failed because of the CShims problem reported in Issue swiftlang#138.
euanh
force-pushed
the
fix-59-linker-flags
branch
from
6da0f0c to
a08cf08
Compare
|
@swift-ci test |
MaxDesiatov
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift Package Manager's linker flag handling changed between 5.9 and 5.10. The flags which work for 5.9 cause linking failures 5.10 and later, and vice versa:
swiftlang/swift-package-manager#7222
This commit generates workaround flags for 5.9 and new-style flags for all other versions.
The EndToEnd tests currently cannot run in CI, so this change was tested locally. (Issue #145)
swift package initbuilt successfully with 5.9.2, 5.10.1 and 6.0.2 SDKs on x86_64 and aarch64.