Fix plugin with custom task invocation using swiftbuild on windows #9553
+24
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
rconnell9
as code owners
jakepetroules
approved these changes
Jan 3, 2026
bkhouri
reviewed
Jan 3, 2026
| // For an executable target we create a `builtTool`. | ||
| else if executableOrBinaryModule.type == .executable { | ||
| return try [.builtTool(name: builtToolName, path: RelativePath(validating: executableOrBinaryModule.name))] | ||
| let exeName = hostTriple.isWindows() ? executableOrBinaryModule.name + ".exe" : executableOrBinaryModule.name |
Contributor
There was a problem hiding this comment.
suggestion: can we use executableName(name:) here so the executable name is updated in single location instead of of having to find all places where we need to add the .exe extension on Windows, and possibly any future platform that may have specific executable suffixes.
daveinglis
force-pushed
the
command_plugin_windows_fix
branch
from
cf86294 to
cd46e43
Compare
Contributor
Author
|
@swift-ci test windows |
daveinglis
force-pushed
the
command_plugin_windows_fix
branch
2 times, most recently
from
92d1b16 to
b89b4ea
Compare
- need to add .exe prefix to .builtTool binary so swiftbuild/llbuild file inputs are correct. closes: swiftlang#9189 rdar://161337478
daveinglis
force-pushed
the
command_plugin_windows_fix
branch
from
b89b4ea to
d64bdd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9189
rdar://161337478