Fix linking error on linux #9306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daveinglis
commented
Oct 29, 2025
daveinglis
commented
- libstdc++ needs to be added when linking if any dependency has a cpp dependency
daveinglis
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand,
rconnell9 and
shawnhyam
as code owners
|
@swift-ci test |
daveinglis
force-pushed
the
fix_linux_link_error
branch
from
b71befd to
27bcc50
Compare
|
@swift-ci test |
|
@swift-ci test windows |
daveinglis
force-pushed
the
fix_linux_link_error
branch
from
27bcc50 to
3e1e26a
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
This seems more appropriate to be done at the Swift Build level - @owenv, what do you think? |
|
Maybe. Could this be modeled using impartedSettings instead of manually propagating the flags from dependency to dependent? |
|
ah, ya, let me try the impartedSettings to see if that will work, forgot about that as a way to pass settings up the chain |
daveinglis
force-pushed
the
fix_linux_link_error
branch
from
3e1e26a to
6f87ef9
Compare
|
@swift-ci test |
|
@swift-ci test windows |
|
@swift-ci test macos |
- libstdc++ needs to be added when linking if any dependency has a cpp dependency
daveinglis
force-pushed
the
fix_linux_link_error
branch
from
6f87ef9 to
8c8cebf
Compare
|
@swift-ci test |
|
@swift-ci test windows |
jakepetroules
approved these changes
Nov 1, 2025
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.