Skip to content

Fix linking error on linux #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix linking error on linux #9306

wants to merge 1 commit into from
+3 −3

Conversation

@daveinglis
Copy link
Contributor

  • libstdc++ needs to be added when linking if any dependency has a cpp dependency

@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis daveinglis force-pushed the fix_linux_link_error branch from b71befd to 27bcc50 Compare October 29, 2025 19:58
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@daveinglis daveinglis force-pushed the fix_linux_link_error branch from 27bcc50 to 3e1e26a Compare October 30, 2025 01:18
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@jakepetroules
Copy link
Contributor

This seems more appropriate to be done at the Swift Build level - @owenv, what do you think?

@owenv
Copy link
Contributor

owenv commented Oct 30, 2025

Maybe. Could this be modeled using impartedSettings instead of manually propagating the flags from dependency to dependent?

@daveinglis
Copy link
Contributor Author

ah, ya, let me try the impartedSettings to see if that will work, forgot about that as a way to pass settings up the chain

@daveinglis daveinglis force-pushed the fix_linux_link_error branch from 3e1e26a to 6f87ef9 Compare October 31, 2025 13:35
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

2 similar comments
@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

@daveinglis
Copy link
Contributor Author

@swift-ci test macos

owenv
owenv approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming tests pass

@daveinglis
Fix linking error on linux
8c8cebf 
- libstdc++ needs to be added when linking if any dependency has a cpp
  dependency
@daveinglis daveinglis force-pushed the fix_linux_link_error branch from 6f87ef9 to 8c8cebf Compare October 31, 2025 19:30
@daveinglis
Copy link
Contributor Author

@swift-ci test

@daveinglis
Copy link
Contributor Author

@swift-ci test windows

jakepetroules
jakepetroules approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@jakepetroules jakepetroules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much cleaner. I think this sort of thing should probably still be handled at the Swift Build level, but this seems fine as an immediate fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@owenv owenv owenv approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@bkhouri bkhouri Awaiting requested review from bkhouri bkhouri is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

@rconnell9 rconnell9 Awaiting requested review from rconnell9 rconnell9 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daveinglis @jakepetroules @owenv