Complete generalized mechanism for validation issue exemptions#92
Merged
dempseyatgithub merged 3 commits intoswiftlang:mainfrom Feb 12, 2026
Merged
Conversation
- Add `reportIssue` method - Checks validation exemptions and - Routes errors and warnings to correct array by type - Add `append` method for returned errors and warnings - Replace errors and warnings arrays with issue wrappers
- Add Range and RangeSet conveniences to improve clarity of exemption definitions - Move existing exemptions for Review field (Discussions) to generalized mechanism - Remove custom exemption mechanism from DiscussionExtractor - Resolves swiftlang#32
heckj
approved these changes
Feb 12, 2026
Member
heckj
left a comment
heckj
left a comment
There was a problem hiding this comment.
Ha! I love it - these steps all align perfectly with other refactoring work I've seen in producing consistent parsing diagnostics for user feedback (Swift's diagnostics engine is crazy complex, but amazing - DocC has one as well that's lovely).
Wraps up the various possible diagnostics into a consistent type to make them easier to wrangle consistently down the road.
The retroactive conformance, that you noted was a low risk, raised my eyebrow, but not badly. I offered an alternative inline, If you're game to consider it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add IssueWrapper struct to encapsulate extraction issue operations
reportIssuemethodappendmethod for returned errors and warningsComplete generalized mechanism for validation issue exemptions