Refactor extractors to be initialized with source#91
Merged
dempseyatgithub merged 3 commits intoswiftlang:mainfrom Feb 12, 2026
Merged
Refactor extractors to be initialized with source#91dempseyatgithub merged 3 commits intoswiftlang:mainfrom
dempseyatgithub merged 3 commits intoswiftlang:mainfrom
Conversation
- Make source a property of extractors - Move source argument from 'extract' method to 'init' - Update ValueExtractor protocol and extractValue function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor extractors to be initialized with source.
Errors are generated during the swift-markdown visitor methods and need access to the source project and proposal number to determine validation exemptions. This change adds a source property to each extractor so the required information is available.