Trace events: add -time-trace to swiftc#2110
Open
MaxDesiatov wants to merge 5 commits intomainfrom
Open
Conversation
-ftime-trace to swiftc-time-trace to swiftc
artemcm
reviewed
Apr 2, 2026
Contributor
artemcm
left a comment
There was a problem hiding this comment.
Is there a chance other tools will benefit from a TimeTrace-like thing in the future and we would need to hoist it out of the driver?
| // Include the main module name in the trace file name to avoid collisions | ||
| // when multiple targets compile the same dependency module. | ||
| if enableTimeTrace { | ||
| commandLine.appendFlag("-time-trace") |
Contributor
There was a problem hiding this comment.
I am not 100% sure how this option interacts with compiler caching, but additional flags/outputs will need to be taken into account. I think we should instead investigate having the dependency scanner specify these flags to module dependency command-line recipes.
Contributor
Author
There was a problem hiding this comment.
I removed it from supplementary outputs and removed suffixes. Do you still think dependency scanner investigation is needed if -time-trace-path is also cacheInvariant?
artemcm
reviewed
Apr 2, 2026
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
07d3105 to
87215f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#88251.
This behaves in the same way as Clang's
-ftime-trace:Generated JSON can be previewed with tools like https://ui.perfetto.dev.