Skip to content

Code actions to convert between computed properties and zero-parameter functions #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Code actions to convert between computed properties and zero-parameter functions #1562

merged 1 commit into from
Nov 14, 2025

Conversation

@antigluten
Copy link
Contributor

@antigluten antigluten commented Jul 10, 2024

Resolves #1246
Continuation of swiftlang/swift-syntax#2721

@antigluten antigluten requested a review from ahoppen as a code owner July 10, 2024 16:06
ahoppen
ahoppen reviewed Nov 12, 2025
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m so sorry, this PR completely slipped past and I only just saw it again while walking through the list of open PRs. The changes look great to me, would you like to rebase the PR on top of main so we can get it merged? If you don’t have the capacity to work on this anymore, I can also take it over the finish line for you.

And sorry again to reply after over a year.

@antigluten antigluten force-pushed the code-action-zero-parameter-function branch from 6d94f19 to 5000d8b Compare November 12, 2025 20:40
@antigluten
Copy link
Contributor Author

antigluten commented Nov 12, 2025

Hey, @ahoppen :)
Thanks for your review!
I've rebased to get it merged.

ahoppen
ahoppen approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for updating the PR after such a long time. 🙏🏽

@ahoppen
Copy link
Member

ahoppen commented Nov 13, 2025

@swift-ci Please test

@antigluten
Copy link
Contributor Author

antigluten commented Nov 13, 2025

@ahoppen, could you help with the pipeline failing?

@bnbarham
Copy link
Contributor

bnbarham commented Nov 13, 2025

For macOS you need to run a swift-format on your changes (Tests/SourceKitLSPTests/CodeActionTests.swift in particular), see https://github.com/swiftlang/sourcekit-lsp/blob/main/CONTRIBUTING.md#formatting. The Windows failure is unrelated and we'll re-run after the formatting is fixed

@antigluten antigluten force-pushed the code-action-zero-parameter-function branch from 5000d8b to 9647dcc Compare November 14, 2025 09:00
@antigluten
Copy link
Contributor Author

antigluten commented Nov 14, 2025

@bnbarham, Thanks for you help!
@ahoppen Could you restart the CI to get it merge?

@ahoppen
Copy link
Member

ahoppen commented Nov 14, 2025

@swift-ci Please test

@ahoppen
Copy link
Member

ahoppen commented Nov 14, 2025

@swift-ci Please test Windows

@ahoppen ahoppen merged commit ff2f984 into swiftlang:main Nov 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahoppen ahoppen ahoppen approved these changes

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Code actions to convert between computed properties and zero-parameter functions

3 participants

@antigluten @ahoppen @bnbarham