🍒 [LLDB] Improve the logging output from InstrumentationRuntimeBoundsSafety plugin #12099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oundsSafety.cpp When d061ddb was landed in our downstream branches this was prior to the code being reviewed again in llvm#169117 which introduced a bunch of NFC changes. This patch incorporates the llvm.org version of `InstrumentationRuntimeBoundsSafety.cpp`. This will make it simpler to consume upstream changes to this file.
…fety plugin (llvm#175082) This change makes several improvements: * Adds some additional logging in the `InstrumentationBoundsSafetyStopInfo` constructor. In particular logging is now emitted along the success path so we can see what the plugin computed. * `ComputeStopReasonAndSuggestedStackFrame` now logs if the debug info vs no debug info path is taken. * `CheckIfRuntimeIsValid` now prints the correct module path. Previously it always printed `<unknown module>`. * `Deactivate` now prints the breakpoint number correctly. Previously this would try to print signed breakpoints IDs as unsigned. This problem was observable because internal breakpoints use negative breakpoint IDs. rdar://167797706 (cherry picked from commit 631645c)
delcypher
added
the
clang:bounds-safety
Author
|
@swift-ci test |
Author
|
@swift-ci please test linux |
Author
|
@swift-ci test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR