Explicitly only use FoundationEssentials where possible - #436
Merged
Merged
Conversation
Collaborator
|
Thank you @t089 |
Contributor
Author
why do I always forget this? on it ... |
sebsto
added a commit
that referenced
this pull request
Dec 25, 2024
#441) This adds a test in the `integration_test.yml` workflow to verify that `libFoundation.so`, `libFoundationInternationalization.so`, and `lib_FoundationICU.so` and not linked the the function binary. This is a follow up from the work make by @t089 to ensure that we don't accidentally link Foundation again in the future. Remove Foundation : #436 Add test in CI to ensure we don't link to foundation : #402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want that the runtime only depends on
FoundationEssentialswhere available (ie. on linux) to ensure small binary size.Motivation:
Smaller binary size is good for lambda deployment and cold-start times. The runtime should only depend on
FoundationEssentials.Modifications:
import Foundationwithimport FoundationEssentialsifFoundationEssentialsis available.Foundationwhich easily happens when you develop on macOS (where always fullFoundationis available).Result:
This should allow builds without linking full
Foundation.