Add guide to run tutorials using a Jupyter Docker image#518
Add guide to run tutorials using a Jupyter Docker image#518mgfernan wants to merge 2 commits intoswift-nav:masterfrom
Conversation
jbangelo
left a comment
jbangelo
left a comment
There was a problem hiding this comment.
Looks good! Thanks for expanding on the documentation! I think we could simplify a couple of the steps with a Dockerfile and maybe even using Docker compose. What do others think about that? Too much overhead? I'd be happy to do the dirty work, either in this PR or in a follow up.
tutorials/README.md
Outdated
| 3. **Launch the Docker container** | ||
|
|
||
| ```sh | ||
| docker run -ti -p 8888:8888 -v `pwd`:/home/jovyan jupyter/datascience-notebook:latest |
There was a problem hiding this comment.
Should we include the --rm flag? https://docs.docker.com/reference/cli/docker/container/run/#rm
There was a problem hiding this comment.
Added in a new commit of this PR. Thanks!
IsakTjernberg
left a comment
IsakTjernberg
left a comment
There was a problem hiding this comment.
Thanks! Just two small comments
tutorials/README.md
Outdated
| **Command breakdown:** | ||
| - `-ti`: Run in interactive mode with a TTY | ||
| - `-p 8888:8888`: Map port 8888 from container to host | ||
| - `-v \`pwd\`/albatross:/home/jovyan`: Mount the albatross directory into the container |
There was a problem hiding this comment.
Nit: the /albatross part here I think should be removed?
Also a question, is the jovyan the name of the users home directory in the Docker datascience-notebook?
tutorials/README.md
Outdated
| - **Port 8888 already in use**: If you get a port binding error, either stop the existing service using port 8888 or use a different port: | ||
|
|
||
| ```sh | ||
| docker run -ti -p 8889:8888 -v `pwd`/albatross:/home/jovyan jupyter/datascience-notebook:latest |
There was a problem hiding this comment.
Nit: Also remove /albatross from here
Hopefully clarifies questions posted by @jbangelo and @IsakTjernberg (thanks!)
3 participants
No description provided.