update RTCM3 signal codes

[jackleckert]

This PR updates the supported RTCM3 MSM signal codes aligning with the demo5 of RTKLIB explorer.

[dgburr]

Can you please maintain the original coding style to make it clearer which values actually changed? This also simplifies the process of merging in changes from upstream.

[dgburr]

Suggestion

const char *msm_sig_gps[32]={
    /* GPS: ref [17] table 3.5-91 */
    ""  ,"1C","1P","1W",""  ,""  ,""  ,"2C","2P","2W",""  ,""  , /*  1-12 */
    ""  ,""  ,"2S","2L","2X",""  ,""  ,""  ,""  ,"5I","5Q","5X", /* 13-24 */
    ""  ,""  ,""  ,""  ,""  ,"1S","1L","1X"                      /* 25-32 */
};
const char *msm_sig_glo[32]={
    /* GLONASS: ref [17] table 3.5-96.
     * 3I, 3Q, 3X, 4A, 4B, 4X, 6A, 6B, 6X are tentative from the
     * PocketSDR extensions */
    ""  ,"1C","1P",""  ,""  ,""  ,""  ,"2C","2P",""  ,""  ,""  , /*  1-12 */
    ""  ,"3I","3Q","3X",""  ,"4A","4B","4X",""  ,"6A","6B","6X", /* 13-24 */
    ""  ,""  ,""  ,""  ,""  ,""  ,""  ,""                        /* 25-32 */
};
const char *msm_sig_gal[32]={
    /* Galileo: ref [17] table 3.5-99.
     * 6D, 6P, 6Z, 7P, 7Z, 8D, 8P, 8X are tentative from the
     * PocketSDR extensions */
    ""  ,"1C","1A","1B","1X","1Z",""  ,"6C","6A","6B","6X","6Z", /*  1-12 */
    ""  ,"7I","7Q","7X",""  ,"8I","8Q","8X",""  ,"5I","5Q","5X", /* 13-24 */
    ""  ,""  ,""  ,""  ,""  ,""  ,""  ,""                        /* 25-32 */
};
const char *msm_sig_qzs[32]={
    /* QZSS: ref [17] table 3.5-105.
     * 1E, 1Z, 1B, 6E, 6Z, 5D, 5P, 5Z are tentative from the
     * PocketSDR extensions */
    ""  ,"1C",""  ,""  ,"1E","1Z","1B",""  ,"6S","6L","6X","6E", /*  1-12 */
    "6Z",""  ,"2S","2L","2X",""  ,""  ,""  ,""  ,"5I","5Q","5X", /* 13-24 */
    "5D","5P","5Z",""  ,""  ,"1S","1L","1X"                      /* 25-32 */
};
const char *msm_sig_sbs[32]={
    /* SBAS: ref [17] table 3.5-102 */
    ""  ,"1C",""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  , /*  1-12 */
    ""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,"5I","5Q","5X", /* 13-24 */
    ""  ,""  ,""  ,""  ,""  ,""  ,""  ,""                        /* 25-32 */
};
const char *msm_sig_cmp[32]={
    /* BeiDou: ref [17] table 3.5-108.
     * 1S, 1L, 1Z, 6D, 6P, 6Z, 7P, 7Z, 8D, 8P, 8X are tentative from the
     * PocketSDR extensions */
    ""  ,"2I","2Q","2X","1S","1L","1Z","6I","6Q","6X","6D","6P", /*  1-12 */
    "6Z","7I","7Q","7X",""  ,"8D","8P","8X",""  ,"5D","5P","5X", /* 13-24 */
    "7D","7P","7Z",""  ,""  ,"1D","1P","1X"                      /* 25-32 */
};
const char *msm_sig_irn[32]={
    /* NavIC/IRNSS: ref [17] table 3.5-108.3.
     * 1D, 1P, 1X, 9B, 9C, 9X, 5B, 5C, and 5X are tentative from the
     * PocketSDR extensions */
    ""  ,"1D","1P","1X",""  ,""  ,""  ,"9A","9B","9C","9X",""  , /*  1-12 */
    ""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,""  ,"5A","5B","5C", /* 13-24 */
    "5X",""  ,""  ,""  ,""  ,""  ,""  , ""                       /* 25-32 */
};

[jackleckert]

@dgburr this is now updated with your suggestion.

[dgburr]

Some of the comments do not match what actually happens in the code:

• msm_sig_gal: the comment says that it adds 6D, 6P, 6Z, 7P, 7Z, 8D, 8P, 8X, but it doesn't actually add anything at all
• msm_sig_cmp: 7D is not listed in the comment
• msm_sig_irn: 9A is missing from the comment

[jackleckert]

@dgburr Good catch, the comments are now updated.

[dgburr]

LGTM (once the build breakage is fixed)