Skip to content

Fixes 2 deprecations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zozlak merged 2 commits into from
Oct 3, 2025
Merged

Fixes 2 deprecations #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5169cf
fixes 2 deprecations
k00ni Oct 3, 2025
5bda1a2
Merge branch 'master' into feature/php8.5
k00ni Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/termTemplates/NumericTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public function __construct(float | null $value = null,
return $termValue > $value;
};
break;
case self::LOWER;
case self::LOWER:
$this->fn = function (float $termValue) use ($value): bool {
return $termValue < $value;
};
Expand Down
2 changes: 1 addition & 1 deletion src/termTemplates/ValueTemplate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,17 +88,17 @@
break;
case self::STARTS:
$this->fn = function (TermInterface $term, string $value): bool {
return str_starts_with((string) $term->getValue(), $value ?? '');

Check failure on line 91 in src/termTemplates/ValueTemplate.php

View workflow job for this annotation

GitHub Actions / phpstan 

Variable $value on left side of ?? always exists and is not nullable.
};
break;
case self::ENDS:
$this->fn = function (TermInterface $term, string $value): bool {
return str_ends_with((string) $term->getValue(), $value ?? '');

Check failure on line 96 in src/termTemplates/ValueTemplate.php

View workflow job for this annotation

GitHub Actions / phpstan 

Variable $value on left side of ?? always exists and is not nullable.
};
break;
case self::CONTAINS:
$this->fn = function (TermInterface $term, string $value): bool {
return str_contains((string) $term->getValue(), $value ?? '');

Check failure on line 101 in src/termTemplates/ValueTemplate.php

View workflow job for this annotation

GitHub Actions / phpstan 

Variable $value on left side of ?? always exists and is not nullable.
};
break;
case self::GREATER:
Expand All @@ -106,7 +106,7 @@
return $term->getValue() > $value;
};
break;
case self::LOWER;
case self::LOWER:
$this->fn = function (TermInterface $term, string $value): bool {
return $term->getValue() < $value;
};
Expand Down
Loading