-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin: serveraction and otp form #529
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ShivanshPlays is attempting to deploy a commit to the Piyush's projects Team on Vercel. A member of the Team first needs to authorize it. |
… modify schema and serveractions to accomodate location functionality
swarooppatilx
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ShivanshPlays pull the latest changes |
okay |
062a6ea
to
73209fd
Compare
@swarooppatilx please check now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
gssoc-ext
GirlScript Summer of Code Extended 2024
hacktoberfest-accepted
Hacktoberfest
level3
GirlScript Summer of Code Level 3 Issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin auth is now functional.
PR2: #518
PR Justification for Level 3
Summary
This PR introduces a new server action for admin functionalities and an OTP form to improve the security and user experience for the admin login process. The changes also include backend modifications to properly handle OTP verification and the handling of the OTP logic on the server side. These updates enhance the login security and overall admin management experience.
Key Enhancements and Changes
1. Server Action for Admin Authentication
2. OTP Form for Admin Login
3. Backend Modifications
4. Documentation Update Required
Points Justification
This PR meets the 40-45 points level due to the following contributions:
Conclusion
This PR introduces significant security improvements with the addition of the OTP-based admin authentication system. The changes also ensure that the login flow for admins is both secure and user-friendly, with appropriate error handling and feedback. The backend modifications are designed to integrate the OTP logic seamlessly, ensuring smooth functionality. The addition of documentation updates ensures that developers and users are well-informed about the new changes and how to use the OTP authentication system effectively.
1.mp4