Returns to the scenario menu after winning a game #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change slightly improves the navigation by saving the menu position so that the user gets back to the next tutorial or challenge after winning a game.
TristanCacqueray
force-pushed
the
prev-menu
branch
from
3933731 to
58936ac
Compare
byorgey
approved these changes
Jun 18, 2022
xsebek
approved these changes
Jun 18, 2022
There was a problem hiding this comment.
Feels great to be back in the menu where I just was 👍
Maybe I am missing something, but how do I quit the game fastest now?
It used to be CtrlQ then -> and Enter and then finally CtrlQ again in the menu, but now I have to press it as many times as I am deep in scenario hierarchy.
|
@TristanCacqueray you can tick the checkbox in #356 after you merge this, sadly it did not get its own issue. 😉 |
TristanCacqueray
added
the
merge me
|
Oops, I merged too soon. When starting the game with the |
TristanCacqueray
added a commit
that referenced
this pull request
Jun 18, 2022
This change fixes an issue introduced with #422 when the game is started directly using the `-s` command line argument. The new behavior is to halt the game when no previous menu is set.
|
@TristanCacqueray yes, but that was the old behaviour, so I don't blame you for not changing that in this PR 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change slightly improves the navigation by saving
the menu position so that the user gets back to the next
tutorial or challenge after winning a game.