feat: add package for apidom-ns-async-api-3 #5032
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glowcloud
reviewed
Oct 27, 2025
| OAuthFlowsVisitor as OAuthFlowsVisitorType, | ||
| } from '@swagger-api/apidom-ns-asyncapi-2'; | ||
|
|
||
| import OAuthFlowsElement from '../../../../elements/OAuthFlows.ts'; |
There was a problem hiding this comment.
We need to rename the imported file to OAuthFlows (seems like that is what it was in Async 2) or:
Suggested change
| import OAuthFlowsElement from '../../../../elements/OAuthFlows.ts'; | |
| import OAuthFlowsElement from '../../../../elements/OauthFlows.ts'; |
| OAuthFlowVisitor as OAuthFlowVisitorType, | ||
| } from '@swagger-api/apidom-ns-asyncapi-2'; | ||
|
|
||
| import OAuthFlowElement from '../../../../elements/OAuthFlow.ts'; |
There was a problem hiding this comment.
We need to rename the imported file to OAuthFlow (seems like that is what it was in Async 2) or:
Suggested change
| import OAuthFlowElement from '../../../../elements/OAuthFlow.ts'; | |
| import OAuthFlowElement from '../../../../elements/OauthFlow.ts'; |
|
|
||
| constructor(options:OperationsVisitorOptions) { | ||
| super(options); | ||
| this.element = new |
There was a problem hiding this comment.
Suggested change
| this.element = new | |
| this.element = new ComponentOperationsElement(); |
| import { Mixin } from 'ts-mixer'; | ||
| import { always } from 'ramda'; | ||
|
|
||
| import Amqp1ServerBindingElement from '../../../../../../elements/bindings/amqp1/Amqp1ServerBinding.ts'; |
There was a problem hiding this comment.
This file seems unnecessary? If not, we need to update each of the paths to point to the correct file:
Suggested change
| import Amqp1ServerBindingElement from '../../../../../../elements/bindings/amqp1/Amqp1ServerBinding.ts'; | |
| import Amqp1ServerBindingElement from '../../../../elements/bindings/amqp1/Amqp1ServerBinding.ts'; |
| correlationIds: AsyncApi2_0Specification.visitors.document.objects.Components.fixedFields.correlationIds, | ||
| replies: { $ref: '#/visitors/value' }, | ||
| replyAddresses: { $ref: '#/visitors/value' }, | ||
| tags: { $ref: '#/visitors/document/objects/Tags' },, |
There was a problem hiding this comment.
Suggested change
| tags: { $ref: '#/visitors/document/objects/Tags' },, | |
| tags: { $ref: '#/visitors/document/objects/Tags' }, |
| import { UnsupportedOperationError } from '@swagger-api/apidom-error'; | ||
| import { OAuthFlowElement } from '@swagger-api/apidom-ns-asyncapi-2'; | ||
|
|
||
| class OAuthFlow extends OAuthFlowElement { |
There was a problem hiding this comment.
Suggested change
| class OAuthFlow extends OAuthFlowElement { | |
| /* eslint-disable class-methods-use-this */ | |
| class OAuthFlow extends OAuthFlowElement { |
| "dependencies": { | ||
| "@babel/runtime-corejs3": "^7.26.10", | ||
| "@swagger-api/apidom-core": "^1.0.0-beta.51", | ||
| "@swagger-api/apidom-ns-asyncapi-2": "workspace:^1.0.0-beta.51", |
There was a problem hiding this comment.
We need to change this and run npm i in the root repo (maybe also in this namespace)
Suggested change
| "@swagger-api/apidom-ns-asyncapi-2": "workspace:^1.0.0-beta.51", | |
| "@swagger-api/apidom-ns-asyncapi-2": "^1.0.0-beta.51", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests