chore: Make eslint rules stricter

.eslintrc.json

@@ -19,8 +19,29 @@
     "plugin:import/errors",
     "plugin:import/warnings"
   ],
-  "plugins": ["@typescript-eslint", "prettier"],
+  "plugins": ["@typescript-eslint", "prettier", "folders", "unicorn"],
   "rules": {
+    // kebab-case
+    "folders/match-regex": [2, "^[a-z-]+$", "/src/"],
+    "unicorn/filename-case": [
+      "error",
+      {
+        "cases": {
+          "camelCase": true,
+          "pascalCase": true
+        }
+      }
+    ],
+    "import/no-internal-modules": [
+      "error", {
+        "forbid": [
+          "commands/*",
+          "features/*",
+          "utils/*",
+          "test/utils/*"
+        ]
+      }
+    ],
     "eqeqeq": "warn",
     "no-throw-literal": "warn",
     "semi": "off",

package.json

@@ -280,8 +280,10 @@
     "del-cli": "^4.0.1",
     "eslint": "^8.5.0",
     "eslint-config-prettier": "^8.3.0",
+    "eslint-plugin-folders": "^1.0.3",
     "eslint-plugin-import": "^2.25.3",
     "eslint-plugin-prettier": "^4.0.0",
+    "eslint-plugin-unicorn": "^40.1.0",
     "glob": "^7.2.0",
     "husky": "^7.0.4",
     "jest": "^27.4.5",

src/commands/extractRangeToNewNote.spec.ts

@@ -8,7 +8,7 @@ import {
   rndName,
   createFile,
   openTextDocument,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('extractRangeToNewNote command', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/commands/openDailyNote.spec.ts

@@ -2,7 +2,7 @@ import { commands, workspace } from 'vscode';
 import moment from 'moment';
 
 import openDailyNote from './openDailyNote';
-import { closeEditorsAndCleanWorkspace } from '../test/testUtils';
+import { closeEditorsAndCleanWorkspace } from '../test/utils';
 
 describe('openDailyNote command', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/commands/openDocumentByReference.spec.ts

@@ -11,7 +11,7 @@ import {
   closeEditorsAndCleanWorkspace,
   toPlainObject,
   updateMemoConfigProperty,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('openDocumentByReference command', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/commands/openRandomNote.spec.ts

@@ -4,7 +4,7 @@ import {
   rndName,
   getOpenedFilenames,
   closeEditorsAndCleanWorkspace,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('openRandomNote command', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/commands/openReferenceBeside.spec.ts

@@ -8,7 +8,7 @@ import {
   rndName,
   toPlainObject,
   waitForExpect,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('openReferenceBeside command', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/commands/openReferenceInDefaultApp.spec.ts

@@ -9,7 +9,7 @@ import {
   closeEditorsAndCleanWorkspace,
   openTextDocument,
   getWorkspaceFolder,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('openReferenceInDefaultApp command', () => {
   beforeEach(async () => {

src/extension.spec.ts

@@ -1,6 +1,6 @@
 import * as vscode from 'vscode';
 
-import { closeEditorsAndCleanWorkspace } from './test/testUtils';
+import { closeEditorsAndCleanWorkspace } from './test/utils';
 
 const MEMO_EXTENSION_ID = 'svsool.markdown-memo';
 

src/features/BacklinksTreeDataProvider.spec.ts

@@ -11,7 +11,7 @@ import {
   toPlainObject,
   updateMemoConfigProperty,
   getMemoConfigProperty,
-} from '../test/testUtils';
+} from '../test/utils';
 
 const getChildren = async () => {
   const backlinksTreeDataProvider = new BacklinksTreeDataProvider();

src/features/DocumentLinkProvider.spec.ts

@@ -5,7 +5,7 @@ import {
   openTextDocument,
   closeEditorsAndCleanWorkspace,
   toPlainObject,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('DocumentLinkProvider', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/ReferenceHoverProvider.spec.ts

@@ -9,7 +9,7 @@ import {
   openTextDocument,
   closeEditorsAndCleanWorkspace,
   toPlainObject,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('ReferenceHoverProvider', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/ReferenceProvider.spec.ts

@@ -7,7 +7,7 @@ import {
   openTextDocument,
   closeEditorsAndCleanWorkspace,
   toPlainObject,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('ReferenceProvider', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/ReferenceRenameProvider.spec.ts

@@ -7,7 +7,7 @@ import {
   rndName,
   openTextDocument,
   closeEditorsAndCleanWorkspace,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('ReferenceRenameProvider', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/codeActionProvider.spec.ts

@@ -1,7 +1,7 @@
 import vscode from 'vscode';
 
 import codeActionProvider from './codeActionProvider';
-import { rndName, createFile, openTextDocument } from '../test/testUtils';
+import { rndName, createFile, openTextDocument } from '../test/utils';
 
 describe('codeActionProvider', () => {
   it('should provide code actions', async () => {

src/features/completionProvider.spec.ts

@@ -12,7 +12,7 @@ import {
   openTextDocument,
   closeEditorsAndCleanWorkspace,
   updateMemoConfigProperty,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('provideCompletionItems()', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/extendMarkdownIt.spec.ts

@@ -10,7 +10,7 @@ import {
   getImgUrlForMarkdownPreview,
   getFileUrlForMarkdownPreview,
   escapeForRegExp,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('extendMarkdownIt feature', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/newVersionNotifier.spec.ts

@@ -2,7 +2,7 @@ import { ExtensionContext } from 'vscode';
 import path from 'path';
 
 import * as newVersionNotifier from './newVersionNotifier';
-import { closeEditorsAndCleanWorkspace } from '../test/testUtils';
+import { closeEditorsAndCleanWorkspace } from '../test/utils';
 
 describe('newVersionNotifier feature', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/referenceContextWatcher.spec.ts

@@ -1,7 +1,7 @@
 import { ExtensionContext } from 'vscode';
 
 import * as referenceContextWatcher from './referenceContextWatcher';
-import { closeEditorsAndCleanWorkspace } from '../test/testUtils';
+import { closeEditorsAndCleanWorkspace } from '../test/utils';
 
 describe('referenceContextWatcher feature', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/features/syntaxDecorations.spec.ts

@@ -6,7 +6,7 @@ import {
   rndName,
   openTextDocument,
   closeEditorsAndCleanWorkspace,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('getDecorations', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/test/utils/index.ts

@@ -0,0 +1 @@
+export * from './utils';

src/test/testUtils.spec.ts → src/test/utils/utils.spec.ts

@@ -1,8 +1,8 @@
 import fs from 'fs';
 
-import { createFile, rndName, cleanWorkspace, closeEditorsAndCleanWorkspace } from './testUtils';
+import { createFile, rndName, cleanWorkspace, closeEditorsAndCleanWorkspace } from './utils';
 
-describe('cleanWorkspace()', function () {
+describe('cleanWorkspace()', () => {
   beforeEach(closeEditorsAndCleanWorkspace);
 
   afterEach(closeEditorsAndCleanWorkspace);

src/test/testUtils.ts → src/test/utils/utils.ts

@@ -4,9 +4,9 @@ import path from 'path';
 import { workspace, Uri, commands, ConfigurationTarget } from 'vscode';
 export { default as waitForExpect } from 'wait-for-expect';
 
-import { cache } from '../workspace';
-import * as utils from '../utils';
-import { WorkspaceCache } from '../types';
+import { cache } from '../../workspace';
+import * as utils from '../../utils';
+import { WorkspaceCache } from '../../types';
 
 const {
   getWorkspaceFolder,
@@ -126,7 +126,7 @@ const getDefaultConfigProperties = (): {
   description?: string;
   type?: string;
 }[] => {
-  return require('../../package.json').contributes.configuration.properties;
+  return require('../../../package.json').contributes.configuration.properties;
 };
 
 export const updateConfigProperty = async (

src/utils/createDailyQuickPick.spec.ts

@@ -1,7 +1,7 @@
 import moment from 'moment';
 
 import createDailyQuickPick from './createDailyQuickPick';
-import { closeEditorsAndCleanWorkspace, createFile } from '../test/testUtils';
+import { closeEditorsAndCleanWorkspace, createFile } from '../test/utils';
 
 describe('createDailyQuickPick()', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/utils/externalUtils.spec.ts

@@ -15,7 +15,7 @@ import {
   createFile,
   openTextDocument,
   rndName,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('lineBreakOffsetsByLineIndex()', () => {
   it('should return offset for a single empty line', () => {

src/utils/searchUtils.spec.ts

@@ -4,7 +4,7 @@ import {
   createFile,
   getWorkspaceFolder,
   rndName,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('search()', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/utils/utils.spec.ts

@@ -46,7 +46,7 @@ import {
   rndName,
   toPlainObject,
   updateConfigProperty,
-} from '../test/testUtils';
+} from '../test/utils';
 
 describe('containsImageExt()', () => {
   test.each(['png', 'jpg', 'jpeg', 'gif'])(

src/workspace/cache/cache.spec.ts

@@ -16,7 +16,7 @@ import {
   closeEditorsAndCleanWorkspace,
   createFile,
   rndName,
-} from '../../test/testUtils';
+} from '../../test/utils';
 
 describe('cacheWorkspace()', () => {
   beforeEach(closeEditorsAndCleanWorkspace);

src/workspace/file-watcher/fileWatcher.spec.ts

@@ -14,7 +14,7 @@ import {
   getWorkspaceCache,
   updateMemoConfigProperty,
   waitForExpect,
-} from '../../test/testUtils';
+} from '../../test/utils';
 
 describe('fileWatcher', () => {
   beforeEach(closeEditorsAndCleanWorkspace);