Skip to content

make manifest.mimeTypes part of the public API #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2022
Merged

make manifest.mimeTypes part of the public API #4302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9afc10e
make manifest.mime part of the public API
Rich-Harris Mar 11, 2022
361fd6c
change mime to mimeTypes
Rich-Harris Mar 14, 2022
9eab407
update changeset
Rich-Harris Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-pants-unite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

Make `manifest.mimeTypes` part of the public API
2 changes: 1 addition & 1 deletion packages/kit/src/core/dev/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ export async function create_plugin(config, cwd) {
manifest = {
appDir: config.kit.appDir,
assets: new Set(manifest_data.assets.map((asset) => asset.file)),
mimeTypes: get_mime_lookup(manifest_data),
_: {
mime: get_mime_lookup(manifest_data),
entry: {
file: `/@fs${runtime}/client/start.js`,
css: [],
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/core/generate_manifest/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export function generate_manifest({ build_data, relative_path, routes, format =
return `{
appDir: ${s(build_data.app_dir)},
assets: new Set(${s(assets)}),
mimeTypes: ${s(get_mime_lookup(build_data.manifest_data))},
_: {
mime: ${s(get_mime_lookup(build_data.manifest_data))},
entry: ${s(build_data.client.entry)},
nodes: [
${Array.from(bundled_nodes.values()).map(node => importer(node.path)).join(',\n\t\t\t\t')}
Expand Down
2 changes: 1 addition & 1 deletion packages/kit/src/runtime/server/page/load_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export async function load_node({

if (options.read) {
const type = is_asset
? options.manifest._.mime[filename.slice(filename.lastIndexOf('.'))]
? options.manifest.mimeTypes[filename.slice(filename.lastIndexOf('.'))]
: 'text/html';

response = new Response(options.read(file), {
Expand Down
3 changes: 2 additions & 1 deletion packages/kit/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,10 @@ export class Server {
export interface SSRManifest {
appDir: string;
assets: Set<string>;
mimeTypes: Record<string, string>;

/** private fields */
_: {
mime: Record<string, string>;
entry: {
file: string;
js: string[];
Expand Down